[superseded] niminst: make linenoise.h optional

[timotheecour]

refs: 2b368bc#commitcomment-37273026
/cc @drjdn does this work for you?

[timotheecour]

adding a flag to niminst (eg --bundleNim) and then passing it from ./koch csources ended up causing a rabbit hole of complexity/extra code just for that 1 boolean flag. Instead I've changed the code so that this works:

./koch csource -d:release -d:nimBundleNimExtra

and made a reference to that in ./koch --help

[drjdn]

@timotheecour I can confirm that this now works again as expected.

[Araq]

With this PR nightlies will be broken once again. Can we please revert this linenoise patch and make nim secret its own tool. It's also blocking my merge of #13065 !!

[drjdn]

@timotheecour could you please back out your modifications to niminst. Your last changes fix my initial issue but I'm onside with @Araq that this should be a separate tool. Currently we have the following in:

Nim/compiler/options.nim

Line 695 in 3dad130

"wrappers", "wrappers/linenoise",

which basically means if you want to use nim's compiler internals and export that to standalone C code you need to copy around a header for a line editing library that is very unlikely to be needed. Exporting C code like this is one of nim's killer features in my opinion. Until an actual REPL that handles the whole language and FFI exists (which would be awesome) I don't see why this needs to be in the compiler directory and definitely not in niminst.

[timotheecour]

all right, see #13478 ; if it gets merged we can close this

[narimiran]

if it gets merged we can close this

Since it has merge_when_passes_CI label, I'm closing this one already.