Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make listCmd honor hint:cc:off #13606

Merged
merged 8 commits into from
Mar 11, 2020
Merged

Make listCmd honor hint:cc:off #13606

merged 8 commits into from
Mar 11, 2020

Conversation

Clyybber
Copy link
Contributor

@Clyybber Clyybber commented Mar 8, 2020

Amends #13603

@Clyybber Clyybber mentioned this pull request Mar 8, 2020
Merged
@Clyybber Clyybber closed this Mar 8, 2020
@Clyybber Clyybber changed the title Disable link hint by default Make listCmd honor hint:cc:off Mar 8, 2020
@Clyybber Clyybber reopened this Mar 8, 2020
@timotheecour
Copy link
Member

timotheecour commented Mar 9, 2020 •
edited
Loading

I wish #13516 (sent out 12 days ago) could get merged first since this will cause conflicts ... @Araq is there anything else needed on #13516 ? (the only comment #13516 (comment) was about build_all.sh, not something actionable for that PR)

@timotheecour
Copy link
Member

@Clyybber needs rebase now that #13516 got merged; let me know if you have any questions since there is some overlap in logic

@Araq Araq added the merge_when_passes_CI mergeable once green label Mar 11, 2020
@timotheecour timotheecour mentioned this pull request Mar 11, 2020
Open
4 tasks
@Clyybber Clyybber merged commit 6b3098c into nim-lang:devel Mar 11, 2020
This was referenced Mar 12, 2020
Closed
Merged
@Clyybber
Copy link
Contributor Author

Note (due to request): This also fixes an obscure HCR bug :)

@timotheecour timotheecour mentioned this pull request Apr 13, 2020
Closed
@timotheecour timotheecour mentioned this pull request Apr 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Clyybber @timotheecour @Araq