Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #13829 #13831

Merged
merged 1 commit into from
Apr 1, 2020
Merged

fix #13829 #13831

merged 1 commit into from
Apr 1, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Apr 1, 2020 •
edited
Loading

fix #13829

@Varriount
Copy link
Contributor

Does this actually fix the root cause of #13829 (which appears to be some conflict between the VM and the deprecated macro)?

@timotheecour
Copy link
Member Author

timotheecour commented Apr 1, 2020 •
edited
Loading

Does this actually fix the root cause

yes. vmops hijacks all procs that have a registered callback (by name), so both overloads of readLines are hijacked; but after PR template expansion happens before, which fixes the bug. In any case, forwardings should be via template, not proc.
deprecated should be irrelevant here.

@cooldome cooldome merged commit fd20213 into nim-lang:devel Apr 1, 2020
@timotheecour timotheecour deleted the pr_fix_13829 branch April 1, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

io.readLines AssertionError on devel
3 participants
@timotheecour @Varriount @cooldome