Linux updates #14170
Merged
Linux updates #14170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
O_TMPFILE: since Linux 3.11 O_PATH: since Linux 2.6.39 O_NOATIME: since Linux 2.6.8 O_DIRECT: since Linux 2.4.10
|
Looks like the conversion to TSa_Family per detect.nim is causing at least one of the tests to fail. If there's interest in this pull request I'll suggest reverting to cint in detect.nim for AF_INET* |
|
The PR is welcome, but as you noticed the |
|
@Araq Fixed detect.nim for AF_INET* |
Araq
reviewed
May 4, 2020
| @@ -244,8 +241,6 @@ type | |||
| st_atim*: Timespec ## Time of last access. | |||
| st_mtim*: Timespec ## Time of last data modification. | |||
| st_ctim*: Timespec ## Time of last status change. | |||
| reserved: array[3, clong] | |||
There was a problem hiding this comment.
This must stay for binary compatibility. NLVM needs it.
There was a problem hiding this comment.
Ah, I was trying to figure out why this was here. Is there a way to hide reserved from iterators?
There was a problem hiding this comment.
Currently not but we need some new annotation like reserved {.padding.}
There was a problem hiding this comment.
=> was discussed in nim-lang/RFCs#205 propoosal 4 {.hidden.}
EchoPouet
pushed a commit
to EchoPouet/Nim
that referenced
this pull request
Jun 13, 2020
* Add posix_memalign() * Add linux-specific open() flags O_TMPFILE: since Linux 3.11 O_PATH: since Linux 2.6.39 O_NOATIME: since Linux 2.6.8 O_DIRECT: since Linux 2.4.10 * Fix Stat type * Fix POSIX AF_INET* const generation
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
May 17, 2022
Undo damage of nim-lang#14170
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
Nov 7, 2022
Undo damage of nim-lang#14170
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
Nov 29, 2022
Undo damage of nim-lang#14170
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
Jun 25, 2023
Undo damage of nim-lang#14170
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
Jun 26, 2023
Undo damage of nim-lang#14170
Merged
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
Undo damage of nim-lang#14170
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
Sep 11, 2023
Undo damage of nim-lang#14170
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
Sep 18, 2023
Undo damage of nim-lang#14170
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
Nov 19, 2023
Undo damage of nim-lang#14170
arnetheduck
added a commit
to arnetheduck/Nim
that referenced
this pull request
Aug 26, 2024
Undo damage of nim-lang#14170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure where we stand on adding
#define _GNU_SOURCEto generate constants, but here's some updates if there is interestSome other flags (flags beyond open()) were inadvertently picked up via detect.nim, and changes were required to detect.nim so that nothing was missing from generated lib/posix/posix_linux_amd64_consts.nim