Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminate() issue #1590

Closed
wants to merge 2 commits into from
Closed

Fix terminate() issue #1590

wants to merge 2 commits into from

Conversation

simonkrauter
Copy link
Contributor

See #1558

@simonkrauter simonkrauter changed the title Fix issue #1558 Fix terminate() issue #1558 Oct 25, 2014
@simonkrauter simonkrauter changed the title Fix terminate() issue #1558 Fix terminate() issue Oct 25, 2014
@jovial
Copy link
Contributor

jovial commented Oct 26, 2014

Is it worth having a "stronger" function, kill, like in the python multiprocess api? Then have terminate only send a sigterm? That way if you have a load of processes that take a while to shutdown, you just spam them all with a terminate and check their exit codes at later time (instead of waiting on each individually).

Also, you might not always want to send a sigterm to the whole group. What if the process takes care of sending a signal to its own children?

The python implementation of kill on windows is just another alias for TerminateProcess. It's worth noting that this only terminates the one process, so for cross-platform code, we might want to replicate this in the posix version (at least by default).

@simonkrauter
Copy link
Contributor Author

Please move your comment to #1558 , so we have all discussion at one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants