Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nim secret dots interfering with prompt #16491

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Dec 28, 2020

fixes what #16478 was attempting to fix

after PR:

XDG_CONFIG_HOME= $nimb secret
Hint: used config file '/Users/timothee/git_clone/nim/Nim_prs/config/nim.cfg' [Conf]
Hint: used config file '/Users/timothee/git_clone/nim/Nim_prs/config/config.nims' [Conf]
.....
>>> discard
>>> echo 1
1
>>> import strutils
.........
>>>

and doesn't have the issues mentioned in #16478 (comment)

links

@timotheecour timotheecour marked this pull request as ready for review December 28, 2020 10:15
@timotheecour timotheecour changed the title fix nim secret dots fix nim secret dots interfering with prompt Dec 28, 2020
@Araq Araq merged commit f9a15db into nim-lang:devel Dec 28, 2020
@narimiran
Copy link
Member

This maybe solves it for nim secret, but it is not the only instance where the stuff is printed on the same line as dots.

Here is the minimal example:

static:
  echo "same line as dots"

@timotheecour
Copy link
Member Author

This maybe solves it for nim secret, but it is not the only instance where the stuff is printed on the same line as dots.

=> fixing this and other issues in #16495

mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants