improve turi.nim tests: js, vm; merge tdecodequery.nim #16500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
They can be removed |
ringabout
approved these changes
Dec 29, 2020
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* improve turi tests: js, vm; merge tdecodequery.nim * improve test * add test in js, improve test * remove matrix: "--styleCheck:hint --panics:on" * fixup
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* improve turi tests: js, vm; merge tdecodequery.nim * improve test * add test in js, improve test * remove matrix: "--styleCheck:hint --panics:on" * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turi tests: js, vm; merge tdecodequery.nim, better organization; no test was removed
notes
@xflywind I see you added
--styleCheck:hint --panics:onin #15336; I've removed these in this PR, let me know if you had a reason for those flags (it did help me find #16499 though)timeout: 60.0? safe to remove ? it runs in under 1s locallyfuture work
For --styleCheck:error we should instead do something more general that'd apply to all tests (eg adding it to tests/config.nims (plus, if needed, adding
--styleCheck:offfor not yet fixed tests) (refs timotheecour#64 (comment))