fix #16576: honor matrix in testament by making such tests non joinable #16577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_fix_testament_matrix_joinable
branch
from
7292bc0 to
55732af
Compare
timotheecour
changed the title
timotheecour
force-pushed
the
pr_fix_testament_matrix_joinable
branch
from
0888475 to
82a8f14
Compare
ringabout
reviewed
Jan 4, 2021
| @@ -656,7 +660,7 @@ proc runJoinedTest(r: var TResults, cat: Category, testsDir: string) = | |||
| writeFile(megatestFile, megatest) | |||
|
|
|||
| let root = getCurrentDir() | |||
| let args = ["c", "--nimCache:" & outDir, "-d:testing", "--listCmd", "--path:" & root, megatestFile] | |||
| let args = ["c", "--nimCache:" & outDir, "-d:testing", "-d:nimMegatest", "--listCmd", "--path:" & root, megatestFile] | |||
There was a problem hiding this comment.
So joinable tests will have nimMegatest defined?
Please add docs for it.
There was a problem hiding this comment.
it's only meant for testing correctness of logic of whether a test is joined, but sure, tracking this here timotheecour#64 (comment)
ringabout
approved these changes
Jan 4, 2021
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
…n joinable (nim-lang#16577) * refs nim-lang#16576: honor matrix in testament by making such tests non joinable * add tests + misc fixes * fix test for i386 with -d:danger
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…n joinable (nim-lang#16577) * refs nim-lang#16576: honor matrix in testament by making such tests non joinable * add tests + misc fixes * fix test for i386 with -d:danger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrixspec #16576matrixin spec should prevent test from joining megatest #16340