Fix macros.quote custom op symbol interpolation. #17256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a workaround/fix for nim-lang#7589. nim-lang#7589 Updated docs and tutorial to reflect change. Updated runnableExamples to include an example.
timotheecour
reviewed
Mar 4, 2021
| @@ -324,14 +342,14 @@ possible with it. | |||
| Strformat | |||
| --------- | |||
|
|
|||
| In the Nim standard library, the ``strformat`` library provides a | |||
| In the Nim standard library, the `strformat` library provides a | |||
There was a problem hiding this comment.
unrelated to this PR, and won't render properly in github until you add .. default-role:: code as described in #17028
PR welcome for changing double backticks to single backticks in rst files in a dedicated PR(s) (you can batch them as needed, preferably manual.rst should be its own PR as it's large) using the same approach as #17028, I can review it fast.
There was a problem hiding this comment.
I can review it fast
unfortunately, #17260 happened
ringabout
pushed a commit
to ringabout/Nim
that referenced
this pull request
Mar 22, 2021
Provides a workaround/fix for nim-lang#7589. nim-lang#7589 Updated docs and tutorial to reflect change. Updated runnableExamples to include an example. Co-authored-by: name <name@example.com>
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
Provides a workaround/fix for nim-lang#7589. nim-lang#7589 Updated docs and tutorial to reflect change. Updated runnableExamples to include an example. Co-authored-by: name <name@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7589
Updated docs and tutorial to reflect change.
Updated runnableExamples to include an example.