Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

further progress on rst roles & directives (fix #17646) #17659

Merged
merged 3 commits into from
Apr 8, 2021
Merged

further progress on rst roles & directives (fix #17646) #17659

merged 3 commits into from
Apr 8, 2021

Conversation

a-mr
Copy link
Contributor

@a-mr a-mr commented Apr 6, 2021

  • now any refname symbol is allowed in a role name according to the spec, not just single words
  • the same name extraction is used for directives (it was implemented differently for them — oppositely, too lax)
  • added warnings to fix rst: invalid use of admonition silently removes line #17646 for directives
  • fixed wrong warning for roles
  • + tests for those warnings
  • fixed a crash when any unknown role is used in the prefix form (e.g. :unknown:`text`)

cc @narimiran @timotheecour

@a-mr a-mr mentioned this pull request Apr 7, 2021
Open
28 tasks
@Araq Araq merged commit 4268745 into nim-lang:devel Apr 8, 2021
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
@a-mr @PMunch
further progress on rst roles & directives (fix nim-lang#17646) (nim-…
634321f 
…lang#17659)

* further progress on rst roles & dir-s (fix nim-lang#17646)

* fix documents according to the messages

* fix bug 17 from nim-lang#17340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

@juancarlospaco juancarlospaco juancarlospaco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rst: invalid use of admonition silently removes line
3 participants
@a-mr @Araq @juancarlospaco