Ref #18177 - lbgc.so.5.0 on OpenBSD 6.9 #18180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I've not tried this syntax before, so hopefully it's correct... |
timotheecour
reviewed
Jun 4, 2021
| @@ -1146,7 +1146,7 @@ when defined(boehmgc): | |||
| elif defined(macosx): | |||
| const boehmLib = "libgc.dylib" | |||
| elif defined(openbsd): | |||
| const boehmLib = "libgc.so.4.0" | |||
| const boehmLib = "libgc.so.(4|5).0" | |||
There was a problem hiding this comment.
while this may work, it still sounds fragile when the v6 is introduced in future; could the following work, const boehmLib = "libgc.so" ? (assuming it's a symlink pointing to "latest") ?
There was a problem hiding this comment.
Unfortunately OpenBSD doesn't create such a symlink I don't believe.
There was a problem hiding this comment.
ok, LGTM; but maybe we should support const boehmLib = "libgc.so.*.0" ?
timotheecour
approved these changes
Jun 4, 2021
|
@Araq i'm merging this because nim CI for pulls (not pull_requests, which don't run openbsd unless PR author makes a PR against a branch originating from nim-lang, which only members can do) is red; this change seems correct but waiting for CI won't help because openbsd isn't run (for same rason); after this is merged, let's see if it makes nim CI (for non-PRs) green again |
|
after this PR i see a different, unrelated failure in openbsd: https://builds.sr.ht/~araq/job/519693 |
|
Is this repeatable? It looks like it failed to clone the repository for some reason - this wouldn’t be an issue with Nim as such.
…On Sat, 5 Jun 2021, at 00:13, Timothee Cour wrote:
after this PR i see a different, unrelated failure in openbsd:
https://builds.sr.ht/~araq/job/519693
`#519693] 2021/06/04 22:47:02 Booting image openbsd/latest (default) on
port 22850
[#519693] 2021/06/04 22:47:07 Waiting for guest to settle
[#519693] 2021/06/04 22:47:26 Sending tasks
[#519693] 2021/06/04 22:47:26 Sending build environment
[#519693] 2021/06/04 22:47:27 Installing packages
Warning: Permanently added '[localhost]:22850' (ECDSA) to the list of
known hosts.
quirks-3.633 signed on 2021-06-04T14:08:56Z
New and changed readme(s):
/usr/local/share/doc/pkg-readmes/sdl2
--- +node-12.16.1p1 -------------------
You may wish to add /usr/local/lib/node_modules/npm/man to /etc/man.conf
You may wish to add /usr/local/lib/node_modules/sshpk/man to
/etc/man.conf
[#519693] 2021/06/04 22:47:59 Cloning repositories
Cloning into 'Nim'...
error: 773 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
[#519693] 2021/06/04 22:48:23 Failed to clone repository. If this a
private repository, make sure you've added a suitable SSH key.
[#519693] 2021/06/04 22:48:23
https://man.sr.ht/builds.sr.ht/private-repos.md
[#519693] 2021/06/04 22:48:23 Processing post-failed triggers...
[#519693] 2021/06/04 22:48:24 Sent build results email to Andreas Rumpf
***@***.***>
[#519693] 2021/06/04 22:48:24 Sending webhook...
[#519693] 2021/06/04 22:48:25 Webhook response: 200
[#519693] 2021/06/04 22:48:25 Sent build status to GitHub
[#519693] 2021/06/04 22:48:25 Build failed.
[#519693] 2021/06/04 22:48:25 The build environment will be kept alive
for 10 minutes.
[#519693] 2021/06/04 22:48:25 To log in with SSH and examine it, use
the following command:
[#519693] 2021/06/04 22:48:25
[#519693] 2021/06/04 22:48:25 ssh -t ***@***.***
connect 519693
[#519693] 2021/06/04 22:48:25
[#519693] 2021/06/04 22:48:25 After logging in, the deadline is
increased to your remaining build time.
[#519693] 2021/06/04 22:58:25 Deadline elapsed. Terminating build
environment.
[#519693] 2021/06/04 22:58:25 Error: git clone: exit status 128
`
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18180 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW24P7JVXA6N3C6RB5ADLTRFM2HANCNFSM46DRXMXA>.
|
I think i've seen it before with bsd pipelines; if this keeps happening we should use |
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18177 - OpenBSD 6.9 has
libgc.so.5.0rather than 4.0.