Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes nimPreviewSlimSystem; register echoBinSafe for nimPreviewSlimSystem #20194

Merged
merged 2 commits into from
Aug 24, 2022
Merged

fixes nimPreviewSlimSystem; register echoBinSafe for nimPreviewSlimSystem #20194

merged 2 commits into from
Aug 24, 2022

Conversation

ringabout
Copy link
Member

we can extract common parts (stdout/stderr/stdin) to avoid import std/syncio later.

@ringabout
Copy link
Member Author

echoBinSafe is a compilerproc residing in std/syncio which depends on stdout, the system requires it. We have to import std/syncio in system.nim or move stdout to a sepreate file.

@ringabout ringabout changed the title register echoBinSafe for nimPreviewSlimSystem fixes nimPreviewSlimSystem; register echoBinSafe for nimPreviewSlimSystem Aug 12, 2022
@ringabout ringabout requested a review from Araq August 24, 2022 08:15
@Araq Araq merged commit 12f23d5 into devel Aug 24, 2022
@Araq Araq deleted the pr_echoBinSafe branch August 24, 2022 11:32
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 12f23d5

Hint: mm: orc; threads: on; opt: speed; options: -d:release
163846 lines; 12.301s; 841.242MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
fixes nimPreviewSlimSystem; register echoBinSafe for nimPreviewSlimSy…
b37222b 
…stem (nim-lang#20194)

* register echoBinSafe

* add output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq