Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace if by case in JS isSimpleExpr #20267

Merged
merged 6 commits into from
Sep 6, 2022
Merged

Replace if by case in JS isSimpleExpr #20267

merged 6 commits into from
Sep 6, 2022

Conversation

AmjadHD
Copy link
Contributor

@AmjadHD AmjadHD commented Aug 24, 2022

@Varriount Varriount requested a review from Araq August 25, 2022 07:19
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Aug 25, 2022
@AmjadHD
Copy link
Contributor Author

AmjadHD commented Aug 25, 2022

why is this failing the tests ?

metagn
metagn approved these changes Sep 3, 2022
View reviewed changes
Copy link
Collaborator

@metagn metagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic refactor, seems fine

@Araq Araq merged commit 5d947bb into nim-lang:devel Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 5d947bb

Hint: mm: orc; threads: on; opt: speed; options: -d:release
164036 lines; 15.331s; 842.496MiB peakmem

@AmjadHD AmjadHD deleted the issimpleexpr-case branch September 6, 2022 19:59
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@AmjadHD @capocasa
Replace if by case in JS isSimpleExpr (nim-lang#20267)
936985a 
use case stmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringabout ringabout ringabout approved these changes

@metagn metagn metagn approved these changes

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AmjadHD @metagn @ringabout @Araq @Varriount