Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move smtp to nimble packages #20953

Merged
merged 4 commits into from
Nov 30, 2022
Merged

move smtp to nimble packages #20953

merged 4 commits into from
Nov 30, 2022

Conversation

ringabout
Copy link
Member

@Varriount Varriount requested a review from Araq November 28, 2022 20:17
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Nov 28, 2022
@metagn
Copy link
Collaborator

metagn commented Nov 29, 2022

Note there is a changelog entry that specifically mentions std/smtp, can remove in a later PR though. Also can remove from doc/lib.md

@ringabout
Copy link
Member Author

Yeah, thanks! I missed these markdown files because I happened to filter *.nim in the search.

ringabout added a commit to ringabout/nim_websitecreator that referenced this pull request Nov 29, 2022
@ringabout
require smtp
6a35208 
ref nim-lang/Nim#20953
ref https://github.com/nim-lang/smtp
@ringabout ringabout mentioned this pull request Nov 29, 2022
Closed
@ringabout ringabout requested review from Araq and removed request for Araq November 30, 2022 07:46
@Araq Araq merged commit 17ac8c3 into devel Nov 30, 2022
@Araq Araq deleted the pr_remove_smtp branch November 30, 2022 20:52
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 17ac8c3

Hint: mm: orc; opt: speed; options: -d:release
165393 lines; 7.500s; 614.125MiB peakmem

@metagn metagn mentioned this pull request Nov 30, 2022
Open
survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
@ringabout @survivorm
move smtp to nimble packages (nim-lang#20953)
69305fe 
* move `smtp` to nimble packages

* fixes

* install smtp

* yes
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
move smtp to nimble packages (nim-lang#20953)
d7ef9e9 
* move `smtp` to nimble packages

* fixes

* install smtp

* yes
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @bung87
move smtp to nimble packages (nim-lang#20953)
47937a3 
* move `smtp` to nimble packages

* fixes

* install smtp

* yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ringabout @metagn @Araq @Varriount