type annotations for variable tuple unpacking, better error messages #22611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
metagn
added a commit
to metagn/Nim
that referenced
this pull request
Dec 18, 2023
Araq
pushed a commit
that referenced
this pull request
Dec 18, 2023
narimiran
pushed a commit
that referenced
this pull request
Apr 17, 2024
…22611) * type annotations for variable tuple unpacking, better error messages closes #17989, closes nim-lang/RFCs#339 * update grammar * fix test (cherry picked from commit ba158d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17989, closes nim-lang/RFCs#339
Everything for it to work was already there, just the parser needed to support it.
This is opposed to the
let (a: int, b: int) = ...variant, since this way is more compatible with existing AST, supports the new type inference, and is how some other languages do it which is what convinced me (though Scala supports both).While we're at it also give type and differing length information in the error messages for non-tuples and differing length tuples.
No documentation or changelog yet, probably should have been in 2.0 since it's a grammar addition