Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #22613; Default value does not work with object's discriminator #22614

Merged
merged 6 commits into from
Sep 1, 2023
Merged

fixes #22613; Default value does not work with object's discriminator #22614

merged 6 commits into from
Sep 1, 2023

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Sep 1, 2023 •
edited
Loading

fixes #22613

will make a following PR on objects with a default descriminator and explicit fields initialization later.

@ringabout ringabout marked this pull request as draft September 1, 2023 03:17
@ringabout ringabout marked this pull request as ready for review September 1, 2023 04:08
Araq
Araq reviewed Sep 1, 2023
View reviewed changes
compiler/semobjconstr.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit affd3f7 into devel Sep 1, 2023
16 checks passed
@Araq Araq deleted the ringabout-patch-5 branch September 1, 2023 06:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from affd3f7

Hint: mm: orc; opt: speed; options: -d:release
169464 lines; 9.128s; 611.172MiB peakmem

narimiran pushed a commit that referenced this pull request Apr 17, 2024
@ringabout @narimiran
fixes #22613; Default value does not work with object's discriminator (…
24f3272 
…#22614)

* fixes #22613; Default value does not work with object's discriminator

fixes #22613

* merge branches

* add a test case

* fixes status

* remove outdated comments

* move collectBranchFields into the global scope

(cherry picked from commit affd3f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value does not work with object's discriminator
2 participants
@ringabout @Araq