-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash for invalid toplevel parseStmt/Expr calls #23089
Commits on Dec 18, 2023
-
Make
reject
action check the compiler actually failedNeeded this for writing the test so that I can still check for errors while also testing that the compiler didn't crash
Configuration menu - View commit details
-
Copy full SHA for 2bb8f43 - Browse repository at this point
Copy the full SHA 2bb8f43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8956d1b - Browse repository at this point
Copy the full SHA 8956d1bView commit details -
Assign register with empty node if anything goes wrong
The error flag is checked after anyways so this shouldn't cause problem This stops the segfault so it is accessing something Alternative solution is to check the error flag ourselves and assign an empty node (Or maybe an error node?) if something goes wrong
Configuration menu - View commit details
-
Copy full SHA for dc735f8 - Browse repository at this point
Copy the full SHA dc735f8View commit details -
File never failed so exit code differing is better error than files differing
Configuration menu - View commit details
-
Copy full SHA for f43136a - Browse repository at this point
Copy the full SHA f43136aView commit details -
Revert changing the expected message, instead only check error code a…
…fter messages The other stuff isn't failing for me :/ so think this is the safest option since it should keep backwards compaitability
Configuration menu - View commit details
-
Copy full SHA for 53d89f0 - Browse repository at this point
Copy the full SHA 53d89f0View commit details -
Close the process after reading the error code
On windows `peekExitCode` will always return 0 if read after the process is closed
Configuration menu - View commit details
-
Copy full SHA for 8c05da1 - Browse repository at this point
Copy the full SHA 8c05da1View commit details -
Turns out the error changed since I edited macros.nim
Now I just check the suffix so that editing the file won't have affects
Configuration menu - View commit details
-
Copy full SHA for 9028d71 - Browse repository at this point
Copy the full SHA 9028d71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 650a800 - Browse repository at this point
Copy the full SHA 650a800View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 853aa94 - Browse repository at this point
Copy the full SHA 853aa94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 207b1f3 - Browse repository at this point
Copy the full SHA 207b1f3View commit details