retain postfix node in type section typed AST #23096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR to unchained: SciNim/Unchained#45 I think we should disable NESM indefinitely. We've been maintaining a fork for a year and I don't want to sift through 3000 lines of test output to adapt it. The failing test also seems like it directly matches against tree output of AST, which would now become dependent on the Nim version. |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
|
Sorry, I skipped CI for the last commit, it wasn't actually passing yet. Should be fine after SciNim/Unchained#45 is merged though. |
|
Never mind, some doc tests fail too. |
Araq
pushed a commit
that referenced
this pull request
Dec 18, 2023
Araq
pushed a commit
that referenced
this pull request
Dec 23, 2023
Continued from #23096 which was reverted due to breaking a package and failing docgen tests. Docgen should now work, but ~~a PR is still pending for the package: SciNim/Unchained#45 has been merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22933