Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes addr/hiddenAddr in strictdefs #23477

Merged
merged 9 commits into from
Apr 10, 2024
Merged

fixes addr/hiddenAddr in strictdefs #23477

merged 9 commits into from
Apr 10, 2024

Conversation

ringabout
Copy link
Member

No description provided.

@ringabout ringabout marked this pull request as ready for review April 5, 2024 14:46
ringabout
ringabout commented Apr 5, 2024
View reviewed changes
compiler/sempass2.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit 9b37829 into devel Apr 10, 2024
22 checks passed
@Araq Araq deleted the pr_addr_strict branch April 10, 2024 12:41
@Araq
Copy link
Member

Araq commented Apr 10, 2024

Superb work!

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 9b37829

Hint: mm: orc; opt: speed; options: -d:release
178486 lines; 8.280s; 752.309MiB peakmem

@ringabout ringabout mentioned this pull request Apr 15, 2024
Merged
Araq pushed a commit that referenced this pull request Apr 15, 2024
@ringabout
fixes #23499; don't skip addr when constructing bracketExpr (#23503)
549ef24 
fixes #23499

In the
8990626
the effect of `skipAddr` changed to skip `nkAddr` and `nkHiddenAddr`.
Some old code was not adapted. In the
#23477, the magic `addr` function
was handled in the semantic analysis phase, which causes it be skipped
incorrectly
@mratsim mratsim mentioned this pull request Jul 1, 2024
Closed
@ringabout ringabout mentioned this pull request Jul 3, 2024
Merged
Araq pushed a commit that referenced this pull request Jul 3, 2024
@ringabout
fixes #23784; don't allow fold paths containing nkAddr (#23792)
051a536 
fixes #23784

notes that before #23477, it didn't
fold paths containing `addr`/`unsafeAddr` because it retained the form
of the magic function: `mAddr`.
narimiran pushed a commit that referenced this pull request Oct 28, 2024
@ringabout @narimiran
fixes addr/hiddenAddr in strictdefs (#23477)
fe72db9 
(cherry picked from commit 9b37829)
(cherry picked from commit 744b241e4b7cb8c8d9e21e8a7f078d17d9ef90d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq