Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Farm Hash conditioned upon nimPreviewHashFarm as 64-bit Hash #23735

Merged
merged 2 commits into from
Jun 19, 2024

Commits on Jun 18, 2024

  1. Add Farm Hash conditioned upon nimPreviewHashFarm as 64-bit Hash-

    actually filling hash function for `string` & related.
    
    For the curious, note that `hashData` remains the aboriginal Nim string
    hasher & `import hashes {.all.}` allows simultaneous test/time of {orig,
    murmur, farm} on your favorite CPU & back end compiler.
    
    Update tests also conditioned upon `nimPreviewHashFarm` so they should
    pass either with or without that `define` on.
    
    In `--jsbigint=on` mode, only the lower 32-bits of `Hash` match nimvm &
    run-time values because `type Hash = int` and on JS int=int32, not int64
    as for 64-bit Nim platforms.  Due to the matching, `const` Table should
    match run-time `Table` on all platforms.
    
    To operate in `--jsbigint=off` mode is feasible but needs much "double
    precision mul/xor/ror/shr-arithmetic"-style work.  That is distracting &
    also of questionable value since JS added BigInt in 2018, ringabout
    added Nim support for it in 2021 & `nimPreviewHashFarm` is unlikely to
    swap from an opt-in to an opt-out default before 2025..2026 which will
    have given a backward looking time window of 7..8 years for deployment
    platforms - reasonably generous.
    
    Add a changelog entry for 2.2.
    c-blake committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d15c521 View commit details
    Browse the repository at this point in the history
  2. Address nim-lang#23735 (review)

    and simplify/clarify the language a little while doing so.
    c-blake committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2d7efaa View commit details
    Browse the repository at this point in the history