Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with nimPreviewHashFarm on the 3 main back ends. #23739

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

c-blake
Copy link
Contributor

@c-blake c-blake commented Jun 19, 2024

Assuming CI tests pass (they do for me locally), this should be merged to keep them passing.

@c-blake
Copy link
Contributor Author

c-blake commented Jun 19, 2024

..Unless, of course, we are just switching to this as the default for Nim-2.2 in which case we should reverse the define as per the comments around nimPreviewHashFarm to be like maybe d:nimStringHash2 { for (2)nd after aboriginal hashData hash with this one being the 3rd, really, though longer term it will be nim-version (2) as well }.

Either way, while the Nim CI seems robust to hash-order changing, it's pretty easy to imagine tests within the Packages set changing with a hash order change.

@Araq Araq merged commit 8301533 into nim-lang:devel Jun 22, 2024
16 checks passed
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 8301533

Hint: mm: orc; opt: speed; options: -d:release
179014 lines; 8.498s; 664.309MiB peakmem

@c-blake c-blake deleted the testFarmHash branch July 1, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants