Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nil in cstringArrayToSeq #23747

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Check for nil in cstringArrayToSeq #23747

merged 2 commits into from
Jun 24, 2024

Conversation

yglukhov
Copy link
Member

This fixes crashes in some specific network configurations (as cstringArrayToSeq is used extensively in nativesockets).

Araq
Araq reviewed Jun 21, 2024
View reviewed changes
lib/system.nim Outdated Show resolved Hide resolved
Araq
Araq reviewed Jun 21, 2024
View reviewed changes
lib/system.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit 2c83f94 into nim-lang:devel Jun 24, 2024
17 of 19 checks passed
@yglukhov yglukhov deleted the nil-chk1 branch June 24, 2024 07:36
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 2c83f94

Hint: mm: orc; opt: speed; options: -d:release
179018 lines; 8.679s; 664.691MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yglukhov @Araq