Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set type of object constructor during annotateType #23852

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Set type of object constructor during annotateType #23852

merged 2 commits into from
Jul 17, 2024

Conversation

SirOlaf
Copy link
Contributor

@SirOlaf SirOlaf commented Jul 17, 2024 •
edited
Loading

Fix #23547

Tested locally with the included test, the test from constantine and the original issue.

@Araq Araq added the merge_when_passes_CI mergeable once green label Jul 17, 2024
@Araq Araq merged commit f765898 into nim-lang:devel Jul 17, 2024
18 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from f765898

Hint: mm: orc; opt: speed; options: -d:release
173157 lines; 8.484s; 664.078MiB peakmem

@SirOlaf SirOlaf deleted the fix-obj-type branch July 18, 2024 03:30
@mratsim mratsim mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semi-regression (?): generic typeclass not matching
2 participants
@SirOlaf @Araq