test fixes for #24184 #24195
Draft
test fixes for #24184 #24195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs nim-lang#24184, refs (fixes) nim-lang#23010, nim-lang#22793
refs (fixes) nim-lang#7611, nim-lang#12559, nim-lang#16969, nim-lang#17423 but not nim-lang#23343
metagn
added a commit
to metagn/Nim
that referenced
this pull request
Oct 3, 2024
Araq
pushed a commit
that referenced
this pull request
Oct 3, 2024
fixes #23010, split from #24195 When resemming bracket nodes, the compiler currently unconditionally makes a new node with an array type based on the node. However the VM can generate bracket nodes with `seq` types, which this erases. To fix this, if a bracket node already has a type, we still resem the bracket node, but don't construct a new type for it, instead using the type of the original node. A version of this was rejected that didn't resem the node at all if it was typed, but I can't find it. The difference with this one is that the individual elements are still resemmed. This should fix the break caused by #24184 so we could redo it after this PR but it might still have issues, not to mention the related pre-existing issues like #22793, #12559 etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #24184, refs (fixes) #23010, #22793
Something similar to the
semArrayConstrchanges was rejected before, but I think that version just early returned and didn't sem any elements ifn.typwasn't nil. In this version the elements are still resemmed, a new type just isn't constructed.I'm going to split this into multiple PRs where the redo of #24184 will depend on the others, but not sure if I should split into 2 or 3 PRs since the fix for #22793 is a single line. Edit: No longer the case but I have no idea what depends on what now.
There is also a fix I couldn't get to work (for #7611, #12559, #16969, #17423 but not #23343 (explicit generics for procs)) that isn't necessary for #24184 but I wanted to see if they all worked in tandem.