Tests for v1 closed generics/static issues #8572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
pushed a commit
to timotheecour/Nim
that referenced
this pull request
Aug 8, 2018
* Add tests to confirm nim-lang#7231 is fixed. * Add test for closed nim-lang#6137 * Add test for nim-lang#7141
timotheecour
pushed a commit
to timotheecour/Nim
that referenced
this pull request
Aug 8, 2018
* Add tests to confirm nim-lang#7231 is fixed. * Add test for closed nim-lang#6137 * Add test for nim-lang#7141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for issues tagged v1 that were actually fixed by earlier commits as a "unexpected side-effect".