Undefine some symbols and globalOptions when processing nimscript #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready now. |
data-man
reviewed
Dec 12, 2018
|
Done. |
narimiran
pushed a commit
to narimiran/Nim
that referenced
this pull request
Dec 29, 2018
…m-lang#9945) [backport] * Undefine some symbols when processing nimscript * Undefine taintMode when processing nimscript * Reload .cfg configuration (cherry picked from commit bb85869)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4446
Fixes #8991
Fixes #9420
Fixes #9589
Fixes #9153
Fixes #9120
Note that there is no need to re-enable these symbols because a few lines later we already re-process the command line argumesnts -
Nim/compiler/cmdlinehelper.nim
Line 91 in b104f77