adds nimdir to dump
#1221
Merged
adds nimdir to dump
#1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmgomez
added a commit
to jmgomez/langserver
that referenced
this pull request
May 22, 2024
This depends on nim-lang/nimble#1221 It also needs to be tested in Win. While developing this found an issue with the project discovery, it uses `nim dump` but it doesnt seem to end when Nim is a local dep, it takes too long. Will try to speed it up in the nimble side of things
|
Do not merge it yet, Im going to make it part of |
jmgomez
added a commit
to nim-lang/langserver
that referenced
this pull request
May 29, 2024
* Gets the nimsuggest path from `nimble` when `nimble` has `nimdir` This depends on nim-lang/nimble#1221 It also needs to be tested in Win. While developing this found an issue with the project discovery, it uses `nim dump` but it doesnt seem to end when Nim is a local dep, it takes too long. Will try to speed it up in the nimble side of things * Win works * Adds Nim version to the notification so the user knows what version is used * uses nimble dump for nimdir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.