Improve nimdir selection fixes #1256 #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## returns the nim directory prioritizing the nimBin one if it satisfais the requirement of the project ## otherwise it returns the major version of the nim installed packages that satisfies the requirement of the project (#TODO) ## if no nim package satisfies the requirement of the project it returns the nimBin parent directory ## only used by the `nimble dump` command which is used to drive the lsp
Araq
reviewed
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returns the nim directory prioritizing the nimBin one if it satisfais the requirement of the project
otherwise it returns the major version of the nim installed packages that satisfies the requirement of the project
if no nim package satisfies the requirement of the project it returns the nimBin parent directory
only used by the
nimble dumpcommand which is used to drive the lsp