Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble test keeps git status clean; prevents accidental checking in of binaries etc #786

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

timotheecour
Copy link
Member

  • git status should always be clean when running tests. after this PR (say, from a fresh nimble clone), nimble test should keep git status clean
  • this prevents accidental checking in of binaries etc
  • speaking of which, I git rm tests/nimbleVersionDefine/src/nimbleVersionDefine in this PR
  • try as much as possible to build test artifacts under a single dir (can be improved in future PR's)
  • simplify & more robust/DRY gitignore logic in particular for genarated nims binaries and binaries without extensions

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applaud your fight to keep git status clean, I think your proposal in that issue you wrote has more merit.

tests/config.nims Show resolved Hide resolved
@timotheecour
Copy link
Member Author

@dom96 friendly ping

Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, alright, seems good. Can you rebase?

@timotheecour
Copy link
Member Author

timotheecour commented Feb 4, 2021

PTAL
sadly, CI was green before rebase, but since nimble's CI is red, this PR's CI is now also red

@dom96
Copy link
Collaborator

dom96 commented Feb 4, 2021

Yeah, dunno what's going on with the CI. I created iffy/install-nim#8

@timotheecour
Copy link
Member Author

@dom96 PTAL, finally green

@dom96 dom96 merged commit 686555c into nim-lang:master Mar 16, 2021
@dom96
Copy link
Collaborator

dom96 commented Mar 16, 2021

thanks!

@timotheecour timotheecour deleted the pr_outDir_gitignore branch March 16, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants