[#123] Move some dependencies to devDependencies #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosle
requested review from
carryall,
bterone,
hanam1ni,
hoangmirs,
malparty,
tyrro and
Nihisil
as code owners
rosle
commented
Sep 8, 2022
packages/cra-template/template.json
Outdated
Comment on lines
59
to
61
| "danger-plugin-code-coverage": "1.1.9", | ||
| "danger-plugin-istanbul-coverage": "1.6.2", | ||
| "danger-plugin-jest-codecov": "0.0.8", |
There was a problem hiding this comment.
Seeing from our dangerfile, we're only using istanbul-coverage plugin. So I'll also remove other unused dependencies
// Our dangerfile
import { istanbulCoverage } from 'danger-plugin-istanbul-coverage';
schedule(
istanbulCoverage({
...
rosle
force-pushed
the
chore/123-manage-depedencies-group
branch
from
e113b53 to
91fc424
Compare
Nihisil
approved these changes
Sep 8, 2022
hoangmirs
approved these changes
Sep 8, 2022
hanam1ni
approved these changes
Sep 8, 2022
carryall
approved these changes
Sep 9, 2022
tyrro
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #123
What happened 👀
Insight 📝
N/AProof Of Work 📹
The app is running fine. And I also apply it onto my React IC application. After deploy, it is working fine 👍
Current
package.jsonbootstrapped from the template{ "name": "test-app", "version": "0.1.0", "private": true, "dependencies": { "axios": "0.21.1", "i18next": "21.6.14", "i18next-browser-languagedetector": "6.1.3", "i18next-http-backend": "1.4.0", "react": "^18.2.0", "react-dom": "^18.2.0", "react-i18next": "11.16.1", "react-router-dom": "6.3.0", "react-scripts": "5.0.1", "sass": "1.49.11", "web-vitals": "2.1.4" }, ... "devDependencies": { "@cypress/code-coverage": "3.9.12", "@cypress/instrument-cra": "1.4.0", "@nimblehq/eslint-config-nimble-react": "1.1.0", "@nimblehq/stylelint-config-nimble": "1.0.2", "@testing-library/cypress": "8.0.2", "@testing-library/jest-dom": "5.16.4", "@testing-library/react": "13.1.1", "@testing-library/user-event": "14.1.1", "@types/jest": "27.4.1", "@types/node": "17.0.21", "@types/react": "17.0.40", "@types/react-dom": "17.0.13", "cypress": "9.5.2", "cypress-react-selector": "2.3.16", "danger": "10.9.0", "danger-plugin-istanbul-coverage": "1.6.2", "eslint": "8.11.0", "prettier": "2.6.0", "start-server-and-test": "1.14.0", "stylelint": "14.6.0", "typescript": "4.6.2" } }