[#121] Move Vite folder to packages #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bterone
force-pushed
the
feature/121-poc-move-vite-to-packages
branch
from
36f3d09 to
f265315
Compare
bterone
force-pushed
the
feature/121-poc-move-vite-to-packages
branch
from
41db162 to
1e348f0
Compare
bterone
force-pushed
the
feature/121-poc-move-vite-to-packages
branch
from
7cfd708 to
e4abfc6
Compare
bterone
force-pushed
the
feature/121-poc-move-vite-to-packages
branch
2 times, most recently
from
fa93b0b to
d2e6c4e
Compare
bterone
force-pushed
the
feature/121-poc-move-vite-to-packages
branch
from
d2e6c4e to
ebbea7e
Compare
bterone
changed the title
bterone
requested review from
carryall,
hoangmirs,
malparty,
rosle,
tyrro and
Nihisil
as code owners
malparty
requested changes
Oct 2, 2023
| } | ||
|
|
||
| private async copyTemplateFiles(options: InitTemplateOptions): Promise<void> { | ||
| CliUx.ux.info('Copying template source files...'); |
There was a problem hiding this comment.
Suggested change
| CliUx.ux.info('Copying template source files...'); | |
| CliUx.ux.info('Copying ${selectedTemplate} template source files...'); |
Should/Can we add the template name in the log? 👀
Comment on lines
17
to
20
| return this.downloadTemplateRepository(options) | ||
| .then(() => this.extractDownloadedTemplateFolder(options)) | ||
| .then(() => this.renameFolder(options)) | ||
| .then(() => this.cleanTemporaryFiles(options)); |
There was a problem hiding this comment.
Suggested change
| return this.downloadTemplateRepository(options) | |
| .then(() => this.extractDownloadedTemplateFolder(options)) | |
| .then(() => this.renameFolder(options)) | |
| .then(() => this.cleanTemporaryFiles(options)); | |
| await this.downloadTemplateRepository(options); | |
| await this.extractDownloadedTemplateFolder(options); | |
| await this.renameFolder(options); | |
| return await this.cleanTemporaryFiles(options); |
Long time I haven't dealt with async JS, but as far as I remember, it acts the same but avoids the chained call (stack trace remains cleaner).
There was a problem hiding this comment.
Sure, I wanted to keep changes to a minimum to make it easier to review, however I can change this 👍 😄
packages/cli-tool/src/template/fetchingStrategy/downloadStrategy.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/vite-templatefolder into the/packagesfolder #121What happened 👀
✅ Moved Vite template to under
/packagesdirectory🔴 Removed lerna bootstrap command as it has been deprecated and now uses the package.json workspaces config 😄
✔️ Since moving the vite template to packages, the package-name
%APP_NAME%is no longer valid. We've renamed tonimble-vite-templateand we replace when generating the filesInsight 📝
🙌 With this PR, we allow for copying template files from the packages folder. This is only for the vite-template currently, and if there is NO template reference provided when running the generate command
For now we keep both
Copying template filesstrategy andDownloading templatestrategy to keep options open in the future🔨 Currently we're using
@oclif/testwhich uses mocha and chai under the hood. We want to update to use jest so we can test all future changes following #116Proof Of Work 📹
Tests pass 🎉