Update comments and clarify Tendermint code #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## albatross #1447 +/- ##
=============================================
- Coverage 66.10% 66.01% -0.10%
=============================================
Files 413 413
Lines 52200 52204 +4
=============================================
- Hits 34506 34461 -45
- Misses 17694 17743 +49
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jsdanielh
approved these changes
Mar 16, 2023
…ritten While reading the code, it wasn't directly clear to me that these lines in Tendermint code do not actually change anything in the accounts trie.
jsdanielh
force-pushed
the
hrxi/minor_fixes19
branch
from
ddf66f5
to
d833ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update issue number for cyclic dependencies in Rust Analyzer. rust-lang/rust-analyzer#2414 was closed in favor of rust-lang/rust-analyzer#14167.
Clarify that the changes from Blockchain::commit_accounts are not written. While reading the code, it wasn't directly clear to me that these lines in Tendermint code do not actually change anything in the accounts trie.