Skip to content

Commit

Permalink
Merge branch 'main' into test/forms-1285
Browse files Browse the repository at this point in the history
  • Loading branch information
nimya-aot authored Jun 20, 2024
2 parents 2b172d7 + 98bf7eb commit 4807ffe
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 7 deletions.
23 changes: 17 additions & 6 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<!-- Provide a general summary of your changes in the Title above -->

# Description

<!-- Describe your changes in detail -->
Expand All @@ -7,19 +8,29 @@

## Types of changes

<!-- What types of changes does your code introduce? Uncomment all that apply: -->
<!-- Uncomment the main reason for the change (for example, all feat PRs should include docs and test, but only uncomment feat): -->

<!-- feat (a new feature) -->
<!-- fix (a bug fix) -->

<!-- build (change in build system or dependencies) -->
<!-- ci (change in continuous integration / deployment) -->
<!-- docs (change to documentation) -->
<!-- perf (change to improve performance) -->
<!-- refactor (change to improve code quality) -->
<!-- style (change to code style/formatting) -->
<!-- test (add missing tests or correct existing tests) -->

<!-- Bug fix (non-breaking change which fixes an issue) -->
<!-- New feature (non-breaking change which adds functionality) -->
<!-- Documentation (non-breaking change with enhancements to documentation) -->
<!-- Breaking change (fix or feature that would cause existing functionality to change) -->
<!--
This is a breaking change because ...
-->

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

- [ ] I have read the [CONTRIBUTING](CONTRIBUTING.md) doc
- [ ] I have read the [CONTRIBUTING](/bcgov/common-hosted-form-service/blob/main/CONTRIBUTING.md) doc
- [ ] I have checked that unit tests pass locally with my changes
- [ ] I have run the npm script lint on the frontend and backend
- [ ] I have added tests that prove my fix is effective or that my feature works
Expand Down
5 changes: 4 additions & 1 deletion app/frontend/src/components/forms/ExportSubmissions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ export default {
);
if (response && response.data && !emailExport) {
const blob = new Blob([response.data], {
// Create a UTF-8 Byte Order Mark to handle BC Sans in Excel.
const BOM = new Uint8Array([0xef, 0xbb, 0xbf]);
const blob = new Blob([BOM, response.data], {
type: response.headers['content-type'],
});
const url = window.URL.createObjectURL(blob);
Expand Down

0 comments on commit 4807ffe

Please sign in to comment.