Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add static apps #12

Merged
merged 1 commit into from
Dec 19, 2023
Merged

feat: add static apps #12

merged 1 commit into from
Dec 19, 2023

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented Dec 19, 2023

this adds two types of static "apps":

  • Just a plain index.html
  • A frontend react app built with npm

thirdeyenick
thirdeyenick approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@thirdeyenick thirdeyenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created both apps via nctl and both worked. So LGTM.

@ctrox ctrox merged commit dfcaf14 into main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirdeyenick thirdeyenick thirdeyenick approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctrox @thirdeyenick