Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use builder-base instead of static builder #9

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented Aug 29, 2023

with the static builder the resulting image only has the actual go binary available. Since we want to use things such as sleep in our e2e tests (to test deploy job timeouts) we use builder-base which includes a few more binaries.

with the static builder the resulting image only has the actual go
binary available. Since we want to use things such as `sleep` in our e2e
tests (to test deploy job timeouts) we use builder-base which includes a
few more binaries.
Copy link
Contributor

@thirdeyenick thirdeyenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ctrox ctrox merged commit ab00a95 into main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants