refactor: use zeitwerk to load gem files #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-rodriguez
force-pushed
the
wip/zeitwerk
branch
3 times, most recently
from
1988b3d
to
b05caec
Compare
|
You need to purge GithubActions cache for this to work. It works perfectly on my side : https://github.com/n-rodriguez/netbox-client-ruby/actions/runs/11463755090 |
n-rodriguez
force-pushed
the
wip/zeitwerk
branch
3 times, most recently
from
bf2238a
to
6798781
Compare
|
@thde if you purge GithubActions cache it should work now |
n-rodriguez
force-pushed
the
wip/zeitwerk
branch
from
6798781
to
da10208
Compare
thde
previously approved these changes
Oct 25, 2024
|
@n-rodriguez could you rebase one more time? |
n-rodriguez
force-pushed
the
wip/zeitwerk
branch
from
da10208
to
b28eb80
Compare
done! |
thde
approved these changes
Oct 28, 2024
thde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #86,
You'll need to merge #86 first