Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for isContentEditable #234

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Mar 25, 2022

  1. Added support for isContentEditable

    Some webpages (Youtube comments for example) use <div> as text input so isContentEditable needs be checked in addition.
    
    Relevant minor changes:
    - Allowed double click to trigger popup in text input elements since it won't interfere with text editing like hotkeys do.
    - Added a mouse point save before getTranslation() to avoid the triggered popup displaying in somewhere else when the network is slow and the mouse is moved.
    skygate2012 committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    338eb10 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2022

  1. Small fixes

    - Rectified `exitKey` not being verified (my bad).
    - Added condition for the timeout to prevent triggering `onSelectionEnd` if there's no text selected.
    skygate2012 committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    e88b10b View commit details
    Browse the repository at this point in the history