Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDK 9 compatibility and test #25

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Add JDK 9 compatibility and test #25

merged 1 commit into from
Jan 20, 2018

Conversation

tirkarthi
Copy link
Contributor

@tirkarthi tirkarthi commented Jan 12, 2018

  • Since sun.boot.class.path and java.ext.dirs are removed on JDK 9 filter them for nil
  • Add a test case

Fixes #24

@venantius
Copy link
Collaborator

Hm. This project doesn't seem to be hooked into a CI system, which is a bummer because ideally we'd get to check this test suite against both JDK 8 and JDK 9 on an ongoing basis. But since you've checked this on your computer in both cases hopefully that's good enough for now.

@tirkarthi
Copy link
Contributor Author

Yes, adding a CI is pretty easy. Just got the commit checked with JDK 8 and JDK 9 on Travis CI

Build : https://travis-ci.org/tirkarthi/clojure-complete/builds/329454061

CI config : https://github.com/tirkarthi/clojure-complete/blob/137cffe2b157898d8799da5af6eef8aa8bceb6dd/.travis.yml

@ninjudd
Copy link
Owner

ninjudd commented Jan 16, 2018

I no longer maintain this repository, but I'm happy to make either of you collaborators if you want to merge this or add CI integration. Just let me know.

@tirkarthi
Copy link
Contributor Author

@ninjudd Thanks. I am afraid I am still a beginner with respect to Clojure ecosystem and have no experience with releases.

@venantius
Copy link
Collaborator

@ninjudd I'm afraid I've got a bit too much on my plate to be a "real" maintainer, but if you want to give me collaborator rights I can at least get CI set up and get this merged.

@ninjudd
Copy link
Owner

ninjudd commented Jan 16, 2018

@venantius sounds good. I added you.

@venantius venantius merged commit 10025f0 into ninjudd:master Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants