Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI's cache tags are ambiguous #2454

Closed
oesteban opened this issue Jul 16, 2021 · 0 comments · Fixed by #2457
Closed

CircleCI's cache tags are ambiguous #2454

oesteban opened this issue Jul 16, 2021 · 0 comments · Fixed by #2457
Labels
bug CI
Milestone
20.2.3

Comments

@oesteban
Copy link
Member

oesteban commented Jul 16, 2021 •
edited
Loading

e.g., this tag:

fmriprep/.circleci/config.yml

Line 26 in 7cb3117

- build-v4-{{ .Branch }}-{{ epoch }}

fails with git tags because {{ .Branch }} is empty.
@oesteban oesteban added this to the 20.2.3 milestone Jul 19, 2021
oesteban added a commit that referenced this issue Jul 19, 2021
@oesteban
MAINT: Revise CircleCI's cache tags to avoid mixups between builds
b5cef07 
As a result of the ambiguity of these tags, a tag 20.2.2 was deployed to docker hub containing the 20.1.4 build last Friday.

The misuse of ``{{ epoch }}`` as well as too liberal template matching when loading cached docker images resulted in this situation.

Resolves: #2454.
@oesteban oesteban mentioned this issue Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug CI
Projects
None yet
Milestone
20.2.3
Development

Successfully merging a pull request may close this issue.

MAINT: Revise CircleCI's cache tags to avoid mixups between builds nipreps/fmriprep
1 participant
@oesteban