-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Enable table text wrap and link docstrings to code on GitHub #1258
Conversation
This https://4031-53175327-gh.circle-artifacts.com/0/home/circleci/out/docs/usage.html is indeed much better 👍 There is a test failing because an import in the conf.py (which is surprising, because
So 1) we should not import unavailable modules, and 2) why the conf.py is not ignored? |
The same approach has worked well in other places, like tedana, but I think CI is raising an error because the tests are being run from a different folder. I can replace |
Good news. It looks like the problem was just that docs wasn't being properly ignored, because relative paths (e.g., |
It doesn't look like the docs are linking back to GitHub. Is this expected until it's merged? |
Merging should make that happen. Until then it should just be using |
Let's give it a shot. Thanks. |
Copied from scikit-learn 1.3.2. File initially copied in nipreps#1258.
As far as I can see, we had just added a few lines to tell this vendored script originates in scikit-learn. File initially copied in nipreps#1258, and not changed since.
<!-- Text in these brackets are comments, and won't be visible when you submit your pull request. If this is your first contribution, please take the time to read these, in particular the comment beginning "Welcome, new contributors!". --> ## Changes proposed in this pull request As far as I can see, we had just added a few lines to tell this vendored script originates in scikit-learn. File initially copied in #1258, and [not changed since](https://github.com/nipreps/fmriprep/commits/master/docs/sphinxext/github_link.py), except for #3097 which I shouldn't have applied to a vendored file.
Changes proposed in this pull request
theme_overrides.css
file recommended here to enable text wrap in tables on RTD site. Currently, tables with a lot of text are just very wide and require horizontal scrolling.github_link
function which, when combined withsphinx.ext.linkcode
, links function and class docstring documentation to the actual code on GitHub. Currently,sphinx.ext.viewcode
is used to show a local snapshot of the function or class.Documentation that should be reviewed
Changes to the docs configuration file (
conf.py
) to use the theme override (for text wrapping) and the link code resolver (to link docstrings to GitHub) should be reviewed.