Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Pass sbref files to SyN workflow #3060

Merged
merged 3 commits into from
Jul 31, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions fmriprep/workflows/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,10 +429,20 @@

fmap_estimators = [fmap for fmap in fmap_estimators if fmap.bids_id in used_estimators]

# Simplification: Unused estimators are removed from registry
# This fiddles with a private attribute, so it may break in future
# versions. However, it does mean the BOLD workflow doesn't need to
# replicate the logic that got us to the pared down set of estimators
# here.
final_ids = {fmap.bids_id for fmap in fmap_estimators}
unused_ids = [bids_id for bids_id in fm._estimators if bids_id not in final_ids]
effigies marked this conversation as resolved.
Show resolved Hide resolved
for bids_id in unused_ids:
del fm._estimators[bids_id]

Check warning on line 440 in fmriprep/workflows/base.py

View check run for this annotation

Codecov / codecov/patch

fmriprep/workflows/base.py#L437-L440

Added lines #L437 - L440 were not covered by tests

if fmap_estimators:
config.loggers.workflow.info(
"B0 field inhomogeneity map will be estimated with "
f" the following {len(fmap_estimators)} estimators: "
f"the following {len(fmap_estimators)} estimator(s): "
f"{[e.method for e in fmap_estimators]}."
)

Expand Down Expand Up @@ -563,8 +573,8 @@
elif estimator.method == fm.EstimatorType.ANAT:
from sdcflows.workflows.fit.syn import init_syn_preprocessing_wf

sources = [str(s.path) for s in estimator.sources if s.suffix == "bold"]
source_meta = [s.metadata for s in estimator.sources if s.suffix == "bold"]
sources = [str(s.path) for s in estimator.sources if s.suffix in ("bold", "sbref")]
source_meta = [s.metadata for s in estimator.sources if s.suffix in ("bold", "sbref")]

Check warning on line 577 in fmriprep/workflows/base.py

View check run for this annotation

Codecov / codecov/patch

fmriprep/workflows/base.py#L576-L577

Added lines #L576 - L577 were not covered by tests
syn_preprocessing_wf = init_syn_preprocessing_wf(
omp_nthreads=config.nipype.omp_nthreads,
debug=config.execution.sloppy,
Expand Down
9 changes: 8 additions & 1 deletion fmriprep/workflows/bold/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,14 @@
config.loggers.workflow.info(sbref_msg)

if has_fieldmap:
estimator_key = get_estimator(layout, bold_file if not multiecho else bold_file[0])
from sdcflows import fieldmaps as fm

Check warning on line 292 in fmriprep/workflows/bold/base.py

View check run for this annotation

Codecov / codecov/patch

fmriprep/workflows/bold/base.py#L292

Added line #L292 was not covered by tests

# We may have pruned the estimator collection due to `--ignore fieldmaps`
estimator_key = [

Check warning on line 295 in fmriprep/workflows/bold/base.py

View check run for this annotation

Codecov / codecov/patch

fmriprep/workflows/bold/base.py#L295

Added line #L295 was not covered by tests
key
for key in get_estimator(layout, bold_file if not multiecho else bold_file[0])
if key in fm._estimators
]

if not estimator_key:
has_fieldmap = False
Expand Down