Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scanner to boldref in non-HMC transform filenames #3118

Closed
wants to merge 2 commits into from

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Oct 22, 2023

Closes #3117.

Changes proposed in this pull request

  • Change scanner to boldref for the <source_entities>_from-scanner_to-T1w_mode-image_xfm.txt and <source_entities>_from-T1w_to-scanner_mode-image_xfm.txt transform files.
  • Update the expected outputs for tests.

Documentation that should be reviewed

  • outputs.rst
    • I added comments distinguishing the from-scanner and from-boldref transforms.

image

@effigies
Copy link
Member

Please base all prs against next. There will not be another release from current master.

@tsalo tsalo changed the base branch from master to next October 22, 2023 14:25
@tsalo
Copy link
Collaborator Author

tsalo commented Oct 22, 2023

Fixed. Thanks for the heads up!

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (978ae51) 46.89% compared to head (3808127) 46.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3118   +/-   ##
=======================================
  Coverage   46.89%   46.89%           
=======================================
  Files          53       53           
  Lines        4224     4224           
=======================================
  Hits         1981     1981           
  Misses       2243     2243           
Files Coverage Δ
fmriprep/workflows/bold/outputs.py 20.68% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

effigies commented Nov 3, 2023

@tsalo sorry, I think I've wasted your time. Under next, these will already be renamed:
image

@tsalo
Copy link
Collaborator Author

tsalo commented Nov 4, 2023

Ah, no worries. I'll just close the PR then.

@tsalo tsalo closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BOLD reference to T1w transforms are mislabeled
2 participants