-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Flexibilize "sophisticated" pepolar to allow monomodal execution #3393
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3393 +/- ##
=======================================
Coverage 72.06% 72.06%
=======================================
Files 57 57
Lines 4231 4231
Branches 455 455
=======================================
Hits 3049 3049
Misses 1067 1067
Partials 115 115 ☔ View full report in Codecov by Sentry. |
What use case is this intended to support? |
I have a dataset with all four AP/PA/LR/RL EPIs. This should be easy to handle by topup. |
What about len(suffixes) >= 2, then? Or we could drop the length check altogether and rely on sdcflows to not create estimators with too few inputs. |
The idea is that the four images are of the same modality while also allowing for epi + bold (which should be capture by the other condition, and disallow more than 2 images) |
Got it. Let's add a comment, as I'm sure I'll forget. |
Sure, I'll add it later today
…On Sun, Nov 3, 2024, 13:57 Chris Markiewicz ***@***.***> wrote:
Got it. Let's add a comment, as I'm sure I'll forget.
—
Reply to this email directly, view it on GitHub
<#3393 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAESDRSXEOWKSYYIKKP4HLDZ6YFULAVCNFSM6AAAAABRCP3HQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGQYTQOJVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Changes proposed in this pull request
Documentation that should be reviewed