-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Drop versioneer for hatch backend, fully embrace pyproject.toml #265
Conversation
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
1fb60b1
to
5dc105b
Compare
Codecov ReportBase: 32.43% // Head: 31.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 32.43% 31.66% -0.77%
==========================================
Files 50 49 -1
Lines 4764 4396 -368
==========================================
- Hits 1545 1392 -153
+ Misses 3219 3004 -215
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@effigies since you implemented in fmriprep, mind giving this a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Have not actually looked to see if checkmarks are green...
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Errors introduced in #2914, caught by @mgxd doing the same over in nipreps/nibabies#265.
Following groundwork laid out in nipreps/fmriprep#2914
TODO
MGHImage
s toNifti1Image
s when plotting niworkflows#769 and cut release / pin to dev master