Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Drop versioneer for hatch backend, fully embrace pyproject.toml #265

Merged
merged 48 commits into from
Jan 18, 2023

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Jan 4, 2023

Following groundwork laid out in nipreps/fmriprep#2914

TODO

@mgxd mgxd changed the title MAINT: Drop versioneer for flit_scm MAINT: Drop versioneer for hatch backend, fully embrace pyproject.toml Jan 10, 2023
Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@mgxd mgxd force-pushed the mnt/flit-scm branch 2 times, most recently from 1fb60b1 to 5dc105b Compare January 11, 2023 05:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Base: 32.43% // Head: 31.66% // Decreases project coverage by -0.77% ⚠️

Coverage data is based on head (44eee95) compared to base (957b2b8).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   32.43%   31.66%   -0.77%     
==========================================
  Files          50       49       -1     
  Lines        4764     4396     -368     
==========================================
- Hits         1545     1392     -153     
+ Misses       3219     3004     -215     
Impacted Files Coverage Δ
nibabies/interfaces/multiecho.py 79.31% <ø> (ø)
nibabies/interfaces/workbench.py 88.44% <ø> (ø)
nibabies/tests/test_config.py 100.00% <ø> (ø)
nibabies/workflows/base.py 11.85% <ø> (ø)
nibabies/workflows/bold/base.py 13.38% <ø> (ø)
nibabies/workflows/bold/outputs.py 21.32% <ø> (ø)
nibabies/workflows/bold/stc.py 36.36% <ø> (ø)
nibabies/__about__.py 81.81% <60.00%> (-18.19%) ⬇️
nibabies/__init__.py 100.00% <100.00%> (+30.00%) ⬆️
nibabies/config.py 76.54% <0.00%> (-0.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxd mgxd marked this pull request as ready for review January 17, 2023 19:45
@mgxd
Copy link
Collaborator Author

mgxd commented Jan 17, 2023

@effigies since you implemented in fmriprep, mind giving this a quick look?

@mgxd mgxd requested a review from effigies January 17, 2023 21:22
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Have not actually looked to see if checkmarks are green...

.gitignore Outdated Show resolved Hide resolved
wrapper/pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
wrapper/src/nibabies_wrapper/__main__.py Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@effigies effigies merged commit 5b20166 into nipreps:master Jan 18, 2023
@mgxd mgxd deleted the mnt/flit-scm branch January 18, 2023 15:52
effigies added a commit to nipreps/fmriprep that referenced this pull request Jan 18, 2023
Errors introduced in #2914, caught by @mgxd doing the same over in nipreps/nibabies#265.
@mgxd mgxd added this to the 23.0.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants