Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Extract participant ages from BIDS sources #287

Merged
merged 7 commits into from
May 26, 2023
Merged

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented May 19, 2023

Closes #62

This PR moves participant age from the global level, instead using it at the single subject, single session workflow level.

Things to think about:

  • Keep --age-months command line, or force all input data to require age data in some BIDS file (session/participant)?
  • How will we determine the closest matching template cohort for the default output space?

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage: 41.08% and project coverage change: -0.07 ⚠️

Comparison is base (6e2778a) 31.81% compared to head (641c0c3) 31.75%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   31.81%   31.75%   -0.07%     
==========================================
  Files          54       54              
  Lines        4859     4906      +47     
==========================================
+ Hits         1546     1558      +12     
- Misses       3313     3348      +35     
Impacted Files Coverage Δ
nibabies/cli/run.py 6.66% <ø> (ø)
nibabies/cli/workflow.py 2.73% <0.00%> (+0.07%) ⬆️
nibabies/reports/core.py 19.14% <0.00%> (+1.84%) ⬆️
nibabies/cli/parser.py 2.50% <9.09%> (+0.38%) ⬆️
nibabies/utils/bids.py 28.14% <11.62%> (-8.42%) ⬇️
nibabies/workflows/base.py 26.25% <59.64%> (+14.71%) ⬆️
nibabies/config.py 75.97% <100.00%> (-0.79%) ⬇️
nibabies/tests/test_config.py 100.00% <100.00%> (ø)
nibabies/workflows/bold/base.py 12.94% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxd mgxd marked this pull request as ready for review May 25, 2023 20:36
@mgxd mgxd merged commit 68902bd into master May 26, 2023
@mgxd mgxd deleted the enh/sessions-tsv-age branch May 26, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse potentially available BIDS data
2 participants