Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Goodvoxel projection #301

Merged
merged 22 commits into from
Jun 26, 2023
Merged

FIX: Goodvoxel projection #301

merged 22 commits into from
Jun 26, 2023

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Jun 23, 2023

Incorporates #300

mgxd added 21 commits June 14, 2023 20:36
There is a bug deep within nipype workflow connection / join expansions that either:
- mistakenly uses node.name rather than node._hierarchy to fetch the relevant node or
- reuses a previous JoinNode's `_next_slot_index`

In either case, the end result is some funky indexed connection (in this case it was looking for the fields `bold_fsLRJ3` and `bold_fsLRJ4`.

I spent some time in the rabbit hole and came out empty-handed, but the easiest solution seems to be just renaming them to something unique. Pain.
FIX: "Goodvoxels" projection
@mgxd mgxd marked this pull request as ready for review June 26, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant