Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add separate workflow to run with a single anatomical #316

Merged
merged 14 commits into from
Nov 10, 2023

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Oct 3, 2023

The PR allows processing of data with only a single modality (T1 or T2) anatomical acquisition.

For best results, nibabies still recommends using both modalities in harmony.

@pep8speaks
Copy link

pep8speaks commented Oct 3, 2023

Hello @mgxd! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 755:101: E501 line too long (103 > 100 characters)

Comment last updated at 2023-10-05 15:16:34 UTC

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 163 lines in your changes are missing coverage. Please review.

Comparison is base (edcbd2b) 33.28% compared to head (bc7ee38) 32.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   33.28%   32.81%   -0.47%     
==========================================
  Files          55       55              
  Lines        5195     5315     +120     
==========================================
+ Hits         1729     1744      +15     
- Misses       3466     3571     +105     
Files Coverage Δ
nibabies/utils/bids.py 42.85% <ø> (ø)
nibabies/workflows/anatomical/__init__.py 100.00% <100.00%> (ø)
nibabies/workflows/anatomical/segmentation.py 19.73% <ø> (+0.50%) ⬆️
nibabies/workflows/base.py 25.90% <0.00%> (-0.32%) ⬇️
nibabies/workflows/anatomical/outputs.py 9.93% <9.09%> (+1.27%) ⬆️
nibabies/workflows/anatomical/base.py 10.59% <11.47%> (+2.33%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd marked this pull request as ready for review November 9, 2023 16:05
@mgxd mgxd merged commit aa83bfa into master Nov 10, 2023
9 of 11 checks passed
@mgxd mgxd deleted the enh/single-anat branch November 10, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants