Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new ruff rules #139

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

C409 Unnecessary list comprehension passed to `tuple()` (rewrite as a generator)
C419 Unnecessary list comprehension
UP008 Use `super()` instead of `super(__class__, self)`
RUF022 `__all__` is not sorted
RUF023 `__slots__` is not sorted
PERF401 Use a list comprehension to create a transformed list
FURB188 Prefer `removeprefix` over conditionally replacing with slice.
PGH003 Use specific rule codes when ignoring type issues
TCH002 Move third-party import into a type-checking block
TCH003 Move standard library import into a type-checking block
SIM401 Use `.get()` instead of an `if` block
ISC001 Implicitly concatenated string literals on one line
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 26.10%. Comparing base (67b5f0c) to head (becd952).

Files with missing lines Patch % Lines
nireports/interfaces/reporting/registration.py 0.00% 7 Missing ⚠️
nireports/interfaces/reporting/segmentation.py 0.00% 7 Missing ⚠️
nireports/interfaces/reporting/masks.py 0.00% 6 Missing ⚠️
nireports/assembler/misc.py 0.00% 1 Missing ⚠️
nireports/reportlets/xca.py 0.00% 1 Missing ⚠️
nireports/tools/timeseries.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (67b5f0c) and HEAD (becd952). Click for more details.

HEAD has 60 uploads less than BASE
Flag BASE (67b5f0c) HEAD (becd952)
62 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #139       +/-   ##
===========================================
- Coverage   64.70%   26.10%   -38.60%     
===========================================
  Files          23       23               
  Lines        2618     2616        -2     
  Branches      422      417        -5     
===========================================
- Hits         1694      683     -1011     
- Misses        810     1912     +1102     
+ Partials      114       21       -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant