-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new ruff rules #139
Open
DimitriPapadopoulos
wants to merge
12
commits into
nipreps:main
Choose a base branch
from
DimitriPapadopoulos:ruff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Apply new ruff rules #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C409 Unnecessary list comprehension passed to `tuple()` (rewrite as a generator)
C419 Unnecessary list comprehension
UP008 Use `super()` instead of `super(__class__, self)`
RUF022 `__all__` is not sorted
RUF023 `__slots__` is not sorted
PERF401 Use a list comprehension to create a transformed list
FURB188 Prefer `removeprefix` over conditionally replacing with slice.
PGH003 Use specific rule codes when ignoring type issues
TCH002 Move third-party import into a type-checking block
TCH003 Move standard library import into a type-checking block
SIM401 Use `.get()` instead of an `if` block
ISC001 Implicitly concatenated string literals on one line
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
===========================================
- Coverage 64.70% 26.10% -38.60%
===========================================
Files 23 23
Lines 2618 2616 -2
Branches 422 417 -5
===========================================
- Hits 1694 683 -1011
- Misses 810 1912 +1102
+ Partials 114 21 -93 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.