Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: replace mutable list with tuple in ANTs' workflow #473

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Mar 1, 2020

No description provided.

@pull-assistant
Copy link

pull-assistant bot commented Mar 1, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix: replace mutable list with tuple

Powered by Pull Assistant. Last update 428eb52 ... 428eb52. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #473 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   62.08%   62.13%   +0.04%     
==========================================
  Files          43       43              
  Lines        5091     5087       -4     
  Branches      727      723       -4     
==========================================
  Hits         3161     3161              
+ Misses       1777     1773       -4     
  Partials      153      153              
Flag Coverage Δ
#documentation 33.85% <ø> (ø) ⬆️
#masks ?
#reportlettests 100.00% <ø> (ø) ⬆️
#travis 57.01% <ø> (ø) ⬆️
#unittests 45.19% <ø> (ø) ⬆️
Impacted Files Coverage Δ
niworkflows/interfaces/images.py 55.96% <0.00%> (+0.14%) ⬆️
niworkflows/viz/utils.py 73.76% <0.00%> (+0.19%) ⬆️
niworkflows/interfaces/mni.py 42.52% <0.00%> (+0.24%) ⬆️
niworkflows/utils/bids.py 77.17% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953da16...428eb52. Read the comment docs.

@oesteban oesteban requested a review from effigies March 2, 2020 17:05
@effigies
Copy link
Member

effigies commented Mar 2, 2020

Seems safe.

@oesteban oesteban merged commit 0a6e986 into master Mar 2, 2020
@oesteban oesteban deleted the oesteban-patch-1 branch March 2, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants