Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Generate CIFTI volume structure indices in column-major order #815

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

effigies
Copy link
Member

This "fix" resolves an inconsistency with HCP CIFTI-2 generation. The metadata of our CIFTIs should still have been correctly generated.

Closes #814.

@effigies effigies requested a review from mgxd June 27, 2023 16:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.03 🎉

Comparison is base (83bb10e) 62.78% compared to head (4f38b11) 62.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   62.78%   62.81%   +0.03%     
==========================================
  Files          52       52              
  Lines        6204     6204              
  Branches      910      909       -1     
==========================================
+ Hits         3895     3897       +2     
+ Misses       2122     2121       -1     
+ Partials      187      186       -1     
Flag Coverage Δ
reportlettests ∅ <ø> (∅)
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/interfaces/cifti.py 97.47% <87.50%> (+1.68%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct

@effigies effigies merged commit 92a2f65 into nipreps:master Jun 27, 2023
@effigies effigies deleted the fix/cifti_voxel_ordering branch June 27, 2023 18:55
effigies added a commit to nipreps/fmriprep that referenced this pull request Aug 1, 2023
23.1.4 (August 1, 2023)

Patch release in the 23.1.x series.

This release prioritizes single-band reference BOLD images during SyN-SDC schemes.
Additionally, an indices inconsistency was fixed for CIFTI volumetric data.

* FIX: Pass sbref files to SyN workflow (#3060)
* FIX: Generate CIFTI volume structure indices in column-major order (nipreps/niworkflows#815)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping between MNI152NLin6Asym ijk-coordinates and CIFTI row indices differs from HCP
3 participants